Re: [PATCH v3 05/14] i2c-octeon: Make adapter timeout tunable

From: Jan Glauber
Date: Mon Mar 14 2016 - 08:45:34 EST


On Sat, Mar 12, 2016 at 04:46:12PM +0100, Wolfram Sang wrote:
> On Mon, Mar 07, 2016 at 04:10:48PM +0100, Jan Glauber wrote:
> > From: Peter Swain <pswain@xxxxxxxxxx>
> >
> > Make the i2c adapter timeout a module parameter to allow upper-level
> > target device drivers to retry with their own logic before their own
> > timeouts abort operations.
> >
> > For example, at24 eeprom driver retries for 25ms when -EAGAIN
> > indicates that an eeprom has gone unresponsive while committing
> > a newly written page (5ms on typical devices).
> >
> > Signed-off-by: Peter Swain <pswain@xxxxxxxxxx>
> > Signed-off-by: Jan Glauber <jglauber@xxxxxxxxxx>
>
> i2c-dev has IOCTLs for timeout and retries. Can't you use those?
>

Yes, with these IOCTLs we don't need to add a module parameter
so I'll drop that.