Re: [PATCH v4 0/7] mtd: nand: Fix support for NAND DMA prefetch

From: Franklin S Cooper Jr.
Date: Mon Mar 14 2016 - 10:19:03 EST




On 03/11/2016 08:02 AM, Roger Quadros wrote:
> Franklin,
>
> On 11/03/16 01:56, Franklin S Cooper Jr wrote:
>> NAND DMA prefetch has been broken for awhile and seems to have only
>> worked for SDMA based devices
>>
>> This patchset fixes DMA prefetch to work on both EDMA and SDMA devices
>>
>> Test on:
>> am335x gp evm
>> am437x gp evm
>> am37x gp evm
>>
>> This rev is pretty much the same as v2 which was blocked due to
>> dependencies to Roger's update GPMC/NAND rework.
>>
>> This updated rev removes this dependency.
>>
>> Also it fixes an issue that was introduced when the eDMA driver was
>> recently updated.
>>
>> Links to rev 3 patchset:
>> https://patchwork.ozlabs.org/patch/595631/
>> https://patchwork.ozlabs.org/patch/595626/
>> https://patchwork.ozlabs.org/patch/595628/
>> https://patchwork.ozlabs.org/patch/595630/
>> https://patchwork.ozlabs.org/patch/595627/
>> https://patchwork.ozlabs.org/patch/595629/
>>
>> Links to rev 2 patchset:
>> https://patchwork.kernel.org/patch/7408691/
>> https://patchwork.kernel.org/patch/7408681/
>> https://patchwork.kernel.org/patch/7408661/
>> https://patchwork.kernel.org/patch/7408641/
>> https://patchwork.kernel.org/patch/7408621/
>>
>> Franklin S Cooper Jr (7):
>> ARM: OMAP2+: gpmc-nand: Set omap2-nand's parent dev to GPMC dev
>> ARM: dts: am33xx: Fix GPMC dma properties
>> ARM: dts: am437x: Fix GPMC dma properties
> Can you please fix the gpmc nodes in dm816x.dtsi and dm814x.dtsi as well?
> You can use linux-next tree or [1] to see the latest changes to these files
> that will end up in v4.6 and base your changes on that.
>
> [1] Tony's omap-for-v4.6/dt
> https://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v4.6/dt

Sorry I didn't bother looking at dm816 and dm814 dtsi files
since I assumed it didn't use edma since the recent edma
updates didn't make updates for those devices. My mistake.
I'll update those dtsi files.
>> mtd: nand: omap2: Support parsing dma channel information from DT
>> mtd: nand: omap2: Start dma request before enabling prefetch
>> mtd: nand: omap2: Fix high memory dma prefetch transfer
>> ARM: OMAP2+: Update GPMC and NAND DT binding documentation
>>
>> Documentation/devicetree/bindings/bus/ti-gpmc.txt | 7 +++++-
>> .../devicetree/bindings/mtd/gpmc-nand.txt | 2 +-
>> arch/arm/boot/dts/am33xx.dtsi | 2 +-
>> arch/arm/boot/dts/am4372.dtsi | 2 +-
>> arch/arm/mach-omap2/gpmc-nand.c | 16 ++++++++++++-
>> drivers/mtd/nand/omap2.c | 27 +++++++++-------------
>> 6 files changed, 35 insertions(+), 21 deletions(-)
>>
> cheers,
> -roger