Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

From: Finn Thain
Date: Mon Mar 14 2016 - 23:22:16 EST

On Mon, 14 Mar 2016, Hannes Reinecke wrote:

> Well ... using individual printk() like here might end up in each
> call to be broken up into individual lines.
> You might want to consider using a line buffer here or, better
> still, move to seq_file or debugfs output.

This routine is meant to be called with the lock held in irq mode. I made
it the caller's responsibility to do the locking. It is the only way to
get a point-in-time snapshot of all of the device registers.


> But as the original code did that, too:
> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
> Cheers,
> Hannes