Re: [patch] block-dev: checking for NULL instead of IS_ERR()
From: Christoph Hellwig
Date: Tue Mar 15 2016 - 03:27:14 EST
On Tue, Mar 08, 2016 at 03:05:46PM +0300, Dan Carpenter wrote:
> This should be an IS_ERR() check. mount_pseudo() returns error pointers
> and this function should return the error pointer to its caller as well.
> Fixes: 3684aa7099e0 ('block-dev: enable writeback cgroup support')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Looks fine. Would be much nicer to simply pass possible flags as an
argument to mount_pseudo to avoid this whole dance..
Reviewed-by: Christoph Hellwig <hch@xxxxxx>