Re: linux-next: manual merge of the aio tree with the vfs tree
From: Benjamin LaHaise
Date: Tue Mar 15 2016 - 09:25:00 EST
On Tue, Mar 15, 2016 at 05:35:33AM +0000, Al Viro wrote:
> On Mon, Mar 14, 2016 at 11:24:38AM -0400, Benjamin LaHaise wrote:
> > On Mon, Mar 14, 2016 at 08:35:23AM +0100, Christoph Hellwig wrote:
> > > The aio changes have either been reviewed negatively or not at all. That
> > > tree should be dropped.
> > That isn't solely your decision. If you have comments, please provide
> > constructive feedback, as there are users and use-cases that need this
> > kind of functionality.
> "This kind of functionality" being what, exactly? Bypassing code review?
> It's not that you've made trivial mistakes; everyone does from time to time.
> But failing to post patches with non-trivial interactions outside of the
> subsystem you are familiar with (be it on fsdevel or privately to people who
> work with the areas involved) *AND* failing to recognize that the lack
> of review might be a problem even after having been explicitly told so...
I'm not bypassing code review. The code was sent out back in January,
you were cc'd on it and has been waiting for you to provide some feedback
on the mailing lists, which you haven't done until yesterday. Given that
review has not occurred, I fully well don't expect this series to be
merged until further work is done.
> For fuck sake, you should know better. You are not a newbie with a pet set
> of half-baked patches for his pet application, refering to (unspecified)
> "users that need this kind of functionality" and getting very surprised when
> those mean, rude folks on development lists inform them that code review is
> more than just a good idea.
No, my comment was based on HCH essentially saying that exposure in
linux-next is a bad thing and the tree should be removed. Quite the
opposite -- it's useful in that it lets people see what is going on and
lets me know about conflicts with other work. Removing the tree from
linux-next gets rid of those benefits, and that is what I was objecting
to. Fwiw, I don't think someone should have a veto over what goes in
linux-next. People should provide feedback, not a blanket "drop that".
"Thought is the essence of where you are now."