Re: [PATCH 2/2] misc: nirtfeatures: physical interface elements

[Josh Cartwright]

Hey Kyle-

On Mon, Mar 14, 2016 at 04:55:08PM -0500, Kyle Roeschley wrote:
> From: Gratian Crisan <gratian.crisan@xxxxxx>

From what I understand, this was mostly Aaron's work, so he should get
authorship.  I could be wrong, though, but you'll want to check.

> These changes add support for PIEs (physical interface elements), which
> are defined as physical elements fixed to a controller/chassis with
> which a user can interact (e.g. LEDs and switches) and whose meaning
> is user-defined and implementation-specific.
[..]
> ---
>  drivers/misc/nirtfeatures.c | 753 ++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 694 insertions(+), 59 deletions(-)

This patchset is awkwardly split up, especially because you are removing
what you are adding in the first patch.  I would suggest coming up with
a better patch breakdown that doesn't do this, to make it easier on
reviewers.

Perhaps, breaking it up into a patchset where each patch implements a
different class of functionality (leds, input).

  Josh

Attachment: signature.asc
Description: PGP signature