Re: [PATCH 1/2] Staging: wlan-ng: removed prototype of p80211_stt_findproto() from this file.

From: kbuild test robot
Date: Tue Mar 15 2016 - 15:45:50 EST

Hi Claudiu,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.5 next-20160315]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

config: xtensa-allyesconfig (attached as .config)
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

Note: the linux-review/Claudiu-Beznea/Staging-wlan-ng-removed-prototype-of-p80211_stt_findproto-from-this-file/20160316-032739 HEAD 5518803294d6e4fcd6c066edb94cc30d04949bdb builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/staging/wlan-ng/p80211conv.c: In function 'skb_ether_to_p80211':
>> drivers/staging/wlan-ng/p80211conv.c:156:8: error: implicit declaration of function 'p80211_stt_findproto' [-Werror=implicit-function-declaration]
p80211_stt_findproto(proto)) {
drivers/staging/wlan-ng/p80211conv.c: At top level:
>> drivers/staging/wlan-ng/p80211conv.c:528:5: error: conflicting types for 'p80211_stt_findproto'
int p80211_stt_findproto(u16 proto)
drivers/staging/wlan-ng/p80211conv.c:529:1: note: an argument type that has a default promotion can't match an empty parameter name list declaration
drivers/staging/wlan-ng/p80211conv.c:156:8: note: previous implicit declaration of 'p80211_stt_findproto' was here
p80211_stt_findproto(proto)) {
cc1: some warnings being treated as errors

vim +/p80211_stt_findproto +156 drivers/staging/wlan-ng/p80211conv.c

00b3ed16 Greg Kroah-Hartman 2008-10-02 150 /* tack on SNAP */
82eaca7d Moritz Muehlenhoff 2009-02-08 151 e_snap =
4eb28f71 Johan Meiring 2010-11-06 152 (struct wlan_snap *)skb_push(skb,
4eb28f71 Johan Meiring 2010-11-06 153 sizeof(struct wlan_snap));
00b3ed16 Greg Kroah-Hartman 2008-10-02 154 e_snap->type = htons(proto);
25845388 Pranjal Bhor 2016-01-19 155 if (ethconv == WLAN_ETHCONV_8021h &&
25845388 Pranjal Bhor 2016-01-19 @156 p80211_stt_findproto(proto)) {
82eaca7d Moritz Muehlenhoff 2009-02-08 157 memcpy(e_snap->oui, oui_8021h,
82eaca7d Moritz Muehlenhoff 2009-02-08 158 WLAN_IEEE_OUI_LEN);
00b3ed16 Greg Kroah-Hartman 2008-10-02 159 } else {

:::::: The code at line 156 was first introduced by commit
:::::: 2584538807926344e713548e5210bded8ed22011 staging: wlan-ng: Logical continuation fixes

:::::: TO: Pranjal Bhor <bhor.pranjal@xxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation

Attachment: .config.gz
Description: Binary data