Re: [PATCH] openvswitch: call only into reachable nf-nat code

From: Arnd Bergmann
Date: Wed Mar 16 2016 - 09:57:17 EST

On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote:
> Not related with this patch, just a side note/recommendation.
> I understand this code just got into tree, and that this needs a bit
> work/iterations but this thing above is ugly, I wonder if there is a
> better way to avoid this.
> Probably with some modularization of the openvswitch code this will
> look better, I mean:
> 1) adding Kconfig switches to enable conntrack and NAT support to
> net/openvswitch/Kconfig.
> 2) Move the NAT code to the corresponding openvswitch/nat.c file.
> Just my two cents.

Yes, I think that would be good too. I also found that the driver
used to look like that but it was changed as part of f88f69dd17f1
("openvswitch: Remove conntrack Kconfig option.").