Re: [PATCH 10/17] pinctrl: Add PLX Technology OXNAS pinctrl and gpio driver
From: Neil Armstrong
Date: Wed Mar 16 2016 - 11:00:41 EST
On 03/15/2016 03:56 PM, Linus Walleij wrote:
> On Thu, Mar 3, 2016 at 12:40 PM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>> Add pinctrl and gprio control support to PLX Technology OXNAS SoC Family
> Be a bit more verbose. Is this MIPS? ARM? How many pins does it have? Etc.
>> CC: Ma Haijun <mahaijuns@xxxxxxxxx>
>> CC: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> This driver has some way to go, but let's work on it!
Thanks a lot for the review.
This driver was initially forked from the at91 driver by Jean-Christophe PLAGNIOL-VILLARD, I just
cleaned it up for upstreaming, but yes it must be rewritten.
I think I'll reboot over a clean base, could you give a reference driver I should follow ?
It's a very simple HW, it should be easy.
> There will be more review comments but I look forward to v2 as the first
> step, using more library functions and cutting down the code a bit!
These first comments are precious !
Could I post a v2 separately for review ?
> Linus Walleij