Re: [PATCH] mmc: card: don't use PF_MEMALLOC

From: Jens Axboe
Date: Wed Mar 16 2016 - 11:14:58 EST

On 03/16/2016 08:07 AM, Martin Kepplinger wrote:
Am 2016-03-16 um 15:41 schrieb Jens Axboe:
On 03/16/2016 04:43 AM, Martin Kepplinger wrote:
PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory
reclaim and mm is not in control, strange hang-up or OOM Killer
could happen.

Signed-off-by: Martin Kepplinger <martink@xxxxxxxxx>
I use MMC cards with this change perfectly fine. As I understand it,
even *if* PF_MEMALLOC has a real reason to be here, I think it should
be very well documented.

Did you try swap on mmcblk?

No I haven't even thought about that :) If you know it can be necessary
in that case, it's obviously fine. A comment would still be good though.

That's why it is there! So yes, adding a comment to that effect would be a better path forward.

Jens Axboe