Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

From: Julien Chauveau
Date: Wed Mar 16 2016 - 17:56:15 EST



> Le 16 mars 2016 Ã 15:47, Javier Martinez Canillas <javier@xxxxxxxxxxxx> a Ãcrit :
>
> Hello Andreas,
>
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <chauveau.julien@xxxxxxxxx>
>> Cc: Julien Chauveau <chauveau.julien@xxxxxxxxx>
>> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
>> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
>> ---
>
> Patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

I agree.

Reviewed-by: Julien Chauveau <chauveau.julien@xxxxxxxxx>