Re: [PATCH v2] PCI: designware: move remaining rc setup code to dw_pcie_setup_rc()
From: Pratyush Anand
Date: Thu Mar 17 2016 - 00:28:34 EST
On Wed, Mar 16, 2016 at 5:10 PM, Jisheng Zhang <jszhang@xxxxxxxxxxx> wrote:
> dw_pcie_setup_rc(), as its name indicates, setups the RC. But current
> dw_pcie_host_init() also contains some necessary rc setup code.
> Another reason: the host may lost power during suspend to ram, the RC
> need to be re-setup after resume. The rc can't be correctly resumed
> without the rc setup code in dw_pcie_host_init().
> So this patch moves the code to dw_pcie_setup_rc() to address the above
> two issues. After this patch, each pcie designware driver users could
> call dw_pcie_setup_rc() to re-setup rc when resume back.
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
Seems reasonable. Thanks for the cleanup. :-)
Acked-by: Pratyush Anand <pratyush.anand@xxxxxxxxx>