Re: [PATCH] cpufreq: Do not schedule policy update work in cpufreq_resume()

From: Viresh Kumar
Date: Thu Mar 17 2016 - 02:30:29 EST

On 16-03-16, 14:12, Rafael J. Wysocki wrote:
> No, it won't. This might be applicable to other governors, but not to
> "performance" (look at what it does on _START instead of just
> guessing).
> > So, your patch break things for sure.
> I'm not actually sure it breaks anything.
> Theoretically, it may, but practically? Is there any system out there
> where it makes any difference?

AFAIU, this patch will break currently working governors.

-> cpufreq_resume()
-> cpufreq_governor_performance(START)
-> __cpufreq_driver_target(target_freq = policy->max)
//policy->cur is already set to policy->max before suspend.
if (target_freq == policy->cur)
return 0;

And so, the real frequency stays to 500 MHz and policy->cur contains 1 GHz.