Re: [PATCH v2 10/11] usb: musb: da8xx: Use devm in probe

From: Sergei Shtylyov
Date: Thu Mar 17 2016 - 07:07:51 EST


On 3/17/2016 5:26 AM, David Lechner wrote:

Simplify things a bit by using devm functions where possible.

Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>

v2 changes: This is part of a previous patch that was split. No changes from
previous version.

drivers/usb/musb/da8xx.c | 28 ++++++++--------------------
1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index b03d3b8..50f07a5 100644
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -489,32 +489,27 @@ static int da8xx_probe(struct platform_device *pdev)
struct platform_device *musb;
struct da8xx_glue *glue;
struct platform_device_info pinfo;
- struct clk *clk;

I wouldn't remove this variable to minimize the patch.


MBR, Sergei