Re: [PATCH] ACPI / property: Export a couple of symbols.

From: Rafael J. Wysocki
Date: Thu Mar 17 2016 - 09:00:53 EST


On Thu, Mar 17, 2016 at 9:09 AM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Wed, Mar 16, 2016 at 05:23:19PM -0700, David Daney wrote:
>> From: David Daney <david.daney@xxxxxxxxxx>
>>
>> The acpi_dev_prop_read() and acpi_dev_prop_read_single() can be called
>> by drivers. Add EXPORT_SYMBOL_GPL to them to allow use by modular
>> drivers. This makes them consistent with acpi_dev_get_property() and
>> acpi_node_get_property_reference() which are already exported.
>>
>> Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
>> ---
>> FWIW: We hope to submit soon Cavium Thunder networking patches that
>> fail under modular builds without these exports.
>
> You should not be using these functions directly in drivers.

That's exactly my point.