Re: [PATCH v8 08/10] tpm: Proxy driver for supporting multiple emulated TPMs

From: Stefan Berger
Date: Thu Mar 17 2016 - 13:45:34 EST

On 03/16/2016 04:42 PM, Jarkko Sakkinen wrote:
On Sun, Mar 13, 2016 at 06:54:38PM -0400, Stefan Berger wrote:
+/* above flags */
+#define VTPM_PROXY_FLAG_TPM2 1 /* emulator is TPM 2 */
+/* all supported flags */
This can be moved inside the .c-file?

I can move that.

+#define VTPM_PROXY_MAGIC 0xa1
+ struct vtpm_proxy_new_dev)
Could we simply replace these four lines with one line:

#deifne VTPM_PROXY_IOC_NEW_DEV _IOW('t', 0x00, struct vtpm_proxy_new_dev);

Does this make it better?

I changed the magic but does it matter?

I would keep the magic at '0xa1'. The documentation is written to '0xa1' now and seems to be good just as any other.