Re: [RFC][PATCH v3 1/5] mm/zsmalloc: introduce class auto-compaction
From: Sergey Senozhatsky
Date: Fri Mar 18 2016 - 00:12:07 EST
On (03/18/16 13:03), Minchan Kim wrote:
> > I have some concerns here. WQ_MEM_RECLAIM implies that there is a kthread
> > attached to wq, a rescuer thread, which will be idle until wq declares mayday.
> > But the kthread will be allocated anyway. And we can queue only one global
> > compaction work at a time; so wq does not buy us a lot here and a simple
> > wake_up_process() looks much better. it make sense to use wq if we can have
> > N compaction jobs queued, like I did in my initial patch, but otherwise
> > it's sort of overkill, isn't it?
> If we can use normal wq rather than WQ_MEM_RECLAIM, wq doesn't need
> own kthread attached the work. Right? If so, we can blow away that
> resource reservation problem.
right. if shrinker callbacks will be around (and it seems
they will), then we don't have to guarantee any forward
progress in background compaction. so yes, we can use normal
wq and there is no need in WQ_MEM_RECLAIM.
> > so you want to have
> > zs_free()
> > check pool watermark
> > queue class compaction
> No queue class compaction.
> > queue pool compaction
> Yes. queue pool compaction.
> > ?
> > I think a simpler one will be to just queue global compaction, if pool
> > is fragmented -- compact everything, like we do in shrinker callback.
> That's what I said. :)