Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

[Suravee Suthikulpanit]

Hi Boris,

On 03/18/2016 04:04 PM, Borislav Petkov wrote:
> On Fri, Mar 18, 2016 at 02:07:25PM +0700, Suravee Suthikulpanit wrote:
> > Actually the exposed APIs (in both files) are from the AMD IOMMU driver,
> > which is not necessary x86-specific. They mostly use struct pci_dev, which
> > is also arch-agnostic. It is correct that the current IOMMU IP is only
> > available in x86 systems. However, if AMD plans to use the IOMMU IP in the
> > ARM-based processors in the future, putting these into
> > include/linux/amd-iommu.h would work better.
>
> Let's wait until AMD does that then. Moving the header is the easiest part.

But the whole point is that since we are moving it to consolidate these 
duplicated declarations, I think we should just put it in the most 
common place. The include/linux/amd-iommu.h file is already there. It's 
not like we have to create a brand new file, and then having to move it 
later.

Regards,
Suravee