Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8
From: Vineet Gupta
Date: Fri Mar 18 2016 - 06:20:40 EST
On Friday 18 March 2016 03:22 PM, Arnd Bergmann wrote:
> On Friday 18 March 2016 14:16:23 Vineet Gupta wrote:
>> diff --git a/arch/arc/Makefile b/arch/arc/Makefile
>> index fed12f39d8ce..aeb101e8e674 100644
>> --- a/arch/arc/Makefile
>> +++ b/arch/arc/Makefile
>> @@ -48,9 +48,14 @@ endif
>> upto_gcc44 := $(call cc-ifversion, -le, 0404, y)
>> atleast_gcc44 := $(call cc-ifversion, -ge, 0404, y)
>> atleast_gcc48 := $(call cc-ifversion, -ge, 0408, y)
>> +is_gcc48 := $(call cc-ifversion, -eq, 0408, y)
>> cflags-$(atleast_gcc44) += -fsection-anchors
>> +# gcc 4.8 spits out false positives for default -O3
>> +# disable these for 4.8 and revisit when we upgrade to newer ver
>> +cflags-$(is_gcc48) += $(call cc-disable-warning,maybe-uninitialized,)
>> cflags-$(CONFIG_ARC_HAS_LLSC) += -mlock
>> cflags-$(CONFIG_ARC_HAS_SWAPE) += -mswape
> Is this any better with gcc-4.9 or gcc-5?
I don't think there's a production ARC toolchain with gcc 4.9 which we can use yet
- Claudiu is still in the the middle of upstreaming the new ARC HS port bits so
things are still in flight there. These tools are off of github !
Maybe it's better to add the flag to
> the line that adds -O3 for consistency. We do the same thing for -Os in the
> global Makefile, as that triggers a similar load of warnings.
Sure, but I prefer this to be only for gcc 4.8 as this warning seems to be
healthy in small doses :-) At least it keeps the door open for future discussion
with gcc guys !
The following nested construct actually works - does that look OK to you ?
ARCH_CFLAGS += -O3 $(call cc-ifversion, -lt, 0408, $(call
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html