Re: [RFC/RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

From: Javier Martinez Canillas
Date: Fri Mar 18 2016 - 06:50:56 EST

Hello Chanwoo,

On 03/18/2016 04:55 AM, Chanwoo Choi wrote:
> Hello Javier,
> On 2016ë 03ì 18ì 03:02, Javier Martinez Canillas wrote:
>> Hello Chanwoo
>> On 03/17/2016 01:57 PM, Javier Martinez Canillas wrote:
>> [snip]
>>> Sorry again, this error goes away after I clean the build directory so it
>>> does not happen without this patch-set. Now, I found what's the issue and
>>> is that both the max14577 MFD and regulator drivers have the same object
>>> file name so they both end being called max14577.ko.
>>> This confuses Kbuild and so in the modpost step, the exported symbols by
>>> the MFD driver don't end into Module.symvers. This doesn't happen when
>>> the driver is not a module since symbols come from the vmlinux binary.
>>> I'll post a patch to rename the regulator driver to max14577-regulator,
>>> this will be necessary anyways to have max14577 as a module since Kbuild
>>> also gets confused and don't copy both modules because have the same name.
>> Patch is [0], could you please test the patch-series along with that one
>> and provide your Tested-by? I plan to re-send this series once [0] lands.
> I'll test it on next week and then reply.

Perfect, thanks a lot for your help!

> Best Regards,
> Chanwoo Choi

Best regards,
Javier Martinez Canillas
Open Source Group
Samsung Research America