Re: [PATCH v5 1/4] dt-bindings: power: reset: add document for reboot-mode driver
From: Rob Herring
Date: Fri Mar 18 2016 - 09:14:38 EST
On Fri, Mar 18, 2016 at 3:43 AM, Andy Yan <andy.yan@xxxxxxxxxxxxxx> wrote:
> Hi Rob:
> On 2016å03æ17æ 23:52, Rob Herring wrote:
>> On Tue, Mar 08, 2016 at 08:23:05PM +0800, Andy Yan wrote:
>>> add device tree bindings document for reboot-mode driver
>>> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
>>> +Required properties:
>>> +- compatible: should be "syscon-reboot-mode"
>>> +- offset: offset in the register map for the storage register (in bytes)
>>> +Optional properity:
>>> +- mask: the mask bits of the mode magic value, default set to 0xffffffff
>>> if missing.
>> I can't see how this is used. I would drop it for now.
>> With that change:
>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> The mask is suggested by Moritz Fischer in V2. And I found Tegra did
> indeed only use some bits of one register to store the reboot mode.
And the other bits in the register need to be preserved? Please make
it clear the mask is for the register, not the magic value.
There's also a typo with "properity".