Re: [PATCH v5 6/6] mfd: intel_vuport: Add Intel virtual USB port MFD Driver
From: Greg Kroah-Hartman
Date: Fri Mar 18 2016 - 11:30:19 EST
On Fri, Mar 18, 2016 at 04:43:21PM +0800, Lu Baolu wrote:
> On 03/18/2016 04:09 PM, Lee Jones wrote:
> > On Fri, 18 Mar 2016, Lu Baolu wrote:
> >> Some Intel platforms have an USB port mux controlled by GPIOs.
> >> There's a single ACPI platform device that provides both USB ID
> >> extcon device and a USB port mux device. This MFD driver will
> >> split the 2 devices for their respective drivers.
> >> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> >> Suggested-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
> > This should be at the top.
> > You couldn't have written the patch before it was suggested.
> Yes. I will change this.
> >> Reviewed-by: Felipe Balbi <balbi@xxxxxxxxxx>
> >> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> > What is this sign-off meant to indicate?
> Fengguang's sign-off was added due to folding a patch contributed by
> his kbuild robot.
No, you can't do that, he only signed off on his fixup patch, not your
overall larger patch!
I'm going to stop you now and require you to get this properly reviewed,
and signed-off-by some experienced Intel kernel developers before I look
at this at all. Take advantage of the resources you have, don't force
the community to point out these basic mistakes.
Also, you know I'm not looking at new patches until after -rc1 is out,
so please wait until then before resending.