Re: [PATCH] mac80211: fix order of flag descriptions

From: Luis de Bethencourt
Date: Fri Mar 18 2016 - 13:41:05 EST


On 18/03/16 17:29, Joe Perches wrote:
> On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote:
>> Fix order of mac80211_rx_flags description to match the enum.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
>> ---
>> Hi,
>>
>> I want ahead and fixed the order of the descriptions. checkpatch.pl was giving
>> a warning to my previous patch and I had a hunch it was because the wrong order
>> breaks the parser. Indeed it does and with this patch below checkpatch.pl does
>> not complain about this flag descriptions anymore.
>
> checkpatch complains? About what?
>

warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags'

Is the warning checkpatch.pl gives against my first patch (add doc for
RX_FLAG_DUP_VALIDATED flag). This is silenced by reordering the descriptions to match
the order in the enum.

Thanks,
Luis