Re: [PATCH] crypto: cleaning and refactoring in rsa.c

From: Herbert Xu
Date: Sat Mar 19 2016 - 04:04:03 EST


On Fri, Mar 18, 2016 at 08:39:51PM +0000, maitesin wrote:
> * Removed several unused initializations of variables.
> * Inlined couple of functions.
> * rsa_check_key_length: changed to use only the switch statement.
> * rsa_setkey: refactored the implementation to be closer to the other
> functions in the file.
>
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@xxxxxxxxx>

Nack. I don't think this patch improves the code at all.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt