Re: [GIT PULL] Please pull powerpc/linux.git powerpc-4.6-1 tag
From: Linus Torvalds
Date: Sat Mar 19 2016 - 18:59:52 EST
On Fri, Mar 18, 2016 at 5:07 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> I couldn't convince git request-pull to generate a sane diffstat below, it
> seems to be confused because I merged powerpc-4.5-4 into my next.
Yes, if there are multiple merge bases (particularly cross-merges, but
you can get it just from internal merges of work that started at
different points), a plain "git diff" will often be unable to give
> So I just did the merge and took that diffstat. Hopefully that makes sense.
Yes, that's the way to get a reliable diff if you have more complex history.
Some people do that merge by default (ie both the networking tree and
the ARM SoC trees tend to do this), not just to get the reliable diff,
but also to inform me of the conflicts that they encountered.
So it's actually "good practice", as long as you then send me the
pre-merge state - I still want to do the merge myself to see what's
Exactly like you did, in other words.
At the same time, it's absolutely not required. So if the diffstat
looks odd, you can just send me the incorrect diffstat and just tell
me so. Yes, I will get a different diffstat when I do the merge, but
I can still tell that it's what you intended to send me by just doing
the non-merge diff.
In general, the trees I pull tend to fall into two main camps:
(a) "simple history" maintainers
These maintainers don't pull from sub-maintainers, and that don't
ever hit the issue with "plain git diff cannot give the right end
The plain "git diff" that pull-request does always works for the
simple history case, and I really don't expect these maintainers to do
merges for me anyway, since they should have linear history and just
generally use a simplified git model.
In fact, I will complain loudly if they start doing odd things
like cross-merging etc, because they really really shouldn't, and they
aren't ready and aware of the pain they cause.
(b) the "complex top-level maintainer"
This group does pulls of their own from submaintainers, and can
have fairly complex histories just within their own tree.
This group can encounter the "oops, I don't have a simple merge
base, so 'gid diff' will not give sane results" situation.
This group is also usually savvy enough that they then can handle
it and do the whole "let's do a test merge to see what conflicts I
get, and get a good diff even if there are multiple merge bases".
Of course, it's not _really_ that black-and-white, but it's a
simplified model and close enough.
Basically you should never hit that complicated case unless you are
already using workflows that means that you can handle it, and by then
you usually also end up understanding why clean history and avoiding
back-merges is a good idea etc.
Welcome to that second group.