Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings

From: Andreas Dannenberg
Date: Mon Mar 21 2016 - 10:06:31 EST


On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote:
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> > + FAULTZ pin for error reporting purposes
>
> There's no point in having interrupts-extended here with a single
> interrupt. It is fine to use, but really that's outside the scope of
> this binding. So I'd just document "interrupts" here as that is what
> most docs do, and that implies interrupts-extended could be used.

Hi Rob,
Good point. Will remove it for v2.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc