Re: [patch] direct-io: propagate -ENOSPC errors
From: Christoph Hellwig
Date: Mon Mar 21 2016 - 12:02:16 EST
On Mon, Mar 14, 2016 at 05:10:00PM -0400, Jeff Moyer wrote:
> dio_bio_complete turns all errors into -EIO. This is historical,
> since you used to only get 1 bit precision for errors (BIO_UPTODATE).
> Now that we get actual error codes, we can return the appropriate
> code to userspace. File systems seem to only propagate either EIO
> or ENOSPC, so I've followed suit in this patch.
Do we? Just propagating some errors defintively seems odd. Even
if we do we should have a central helper doing that mapping instead
of opencoding it in various places.