Re: [PATCH net 03/10] net: hns: add uc match for debug ports

From: Yisen Zhuang
Date: Mon Mar 21 2016 - 21:04:09 EST




å 2016/3/21 23:40, David Miller åé:
> From: Yisen Zhuang <Yisen.Zhuang@xxxxxxxxxx>
> Date: Mon, 21 Mar 2016 19:06:34 +0800
>
>> + (void)hns_mac_set_promisc(mac_cb, (u8)!!en);
>
> This cast to void is unnecssary.

I think hns_mac_set_promisc don't need to return a valueï so i will fix it in next submit.

Thanks

>
>> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
>> +{
>> + struct mac_driver *drv = (struct mac_driver *)mac_drv;
>
> Casts from void pointers are unnecessary.

Will fix it in next submit.

Thanks

>
>> +{
>> + struct mac_driver *drv = (struct mac_driver *)mac_drv;
>
> Likewise.

Will fix it in next submit.

Thanks,

Yisen

>
> .
>