Re: [PATCH] Staging: wlan-ng: moved memset() calls after copy_from_user() call

From: Greg KH
Date: Mon Mar 21 2016 - 22:02:23 EST

On Tue, Mar 15, 2016 at 09:53:15PM +0200, Claudiu Beznea wrote:
> This patch moves memset() calls from p80211netdev_ethtool()
> after copy_from_user() call in order to avoid unnecessary
> instruction in case copy_from_user() fails.

Does that really matter? If an error happens, then we are on a "slow
path" and the extra memset didn't matter at all. Don't move code around
for no good reason, and if you think it makes things faster, then you
have to be able to prove it somehow :)


greg k-h