Re: [PATCH 2/9] x86: Add support for rd/wr fs/gs base
From: Thomas Gleixner
Date: Tue Mar 22 2016 - 04:38:15 EST
On Mon, 21 Mar 2016, Andi Kleen wrote:
> On Mon, Mar 21, 2016 at 03:08:46PM -0700, Andy Lutomirski wrote:
> > On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > >> Please add a patch before this one that renames gs to gsbase. This is
> > >> unreadable as is.
> > >
> > > I investigated this now, and it's not straight forward because on 32bit
> > > ->gs is actually gsindex, not gsbase. So with a straight rename you
> > > would end up with index in base on 32bit, which would be confusing.
> > >
> > I would take this inconsistency as a reason why this needs to be fixed
> > before any further changes are made.
> The patchkit doesn't change anything for 32bit, so any inconsistency
> in 32bit is completely orthogonal.
> I don't see how adding a bazillion unrelated changes makes this
> patchkit any better.
The general rule is that we do necessary cleanups before we change or add new
functionality. That's nothing which can be negotiated. Period.