Re: [PATCH] w1: gpio: Fix problematic platform_data usage

From: Ingo Flaschberger
Date: Tue Mar 22 2016 - 07:59:33 EST


Dear Markus,

sorry - missed your reply last year.
The patch seems to work.

Kind regards,
Ingo Flaschberger

On Fri, Apr 10, 2015 at 12:22 PM, Markus Pargmann <mpa@xxxxxxxxxxxxxx> wrote:
> Hi,
>
> On Mon, Mar 09, 2015 at 11:18:58AM +0100, Markus Pargmann wrote:
>> pdev->dev.platform_data should not be overwritten by a driver. This
>> patch fixes this issue by not using platform_get_pdata to get pdata. The
>> DT routine can then simply return a pdata struct with those information.
>>
>> Without this patch the platform_data may be freed twice, by devres and
>> the driver framework.
>>
>> Reported-by: Ingo Flaschberger <ingo.flaschberger@xxxxxxxxx>
>> Cc: <stable@xxxxxxxxxxxxxxx>
>> Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
>
> Did you have time to test this? I would like to send this mainline but a
> Tested-by of you would be nice.
>
> Best Regards,
>
> Markus
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |