Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

From: Oliver Neukum
Date: Tue Mar 22 2016 - 10:31:33 EST


On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote:
> I don't see any point in resuming the device just in order to collect
> operating statistics. If it was already suspended then it wasn't
> operating, so there will be no statistics to collect.

Indeed. In that case the point is moot. But it is correct to ask
the core whether the device is autosuspended at that point rather
than keep a private flag if you can.

All that is relevant only if the upper layers ask for information
that the driver cannot provide without resuming the device.
Those are fundamentally different issues.

Regards
Oliver