Re: [PATCH 1/9] sched: add schedule_timeout_idle()
From: Johannes Weiner
Date: Tue Mar 22 2016 - 13:58:01 EST
On Tue, Mar 22, 2016 at 02:22:49PM +0100, Peter Zijlstra wrote:
> On Tue, Mar 22, 2016 at 02:08:23PM +0100, Michal Hocko wrote:
> > On Tue 22-03-16 13:51:13, Peter Zijlstra wrote:
> > If that sounds like a more appropriate plan I won't object. I can simply
> > change my patch to do __set_current_state and schedule_timeout.
> I dunno, I just think these wrappers are silly.
Adding out-of-line, exported wrappers for every single task state is
kind of silly. But it's still a common operation to wait in a certain
state, so having a single function for that makes sense. Kind of like
spin_lock_irqsave and friends.
Maybe this would be better?:
static inline long schedule_timeout_state(long timeout, long state)