Re: regmap: mmio: regression in pre-v4.6-rc1

From: Mark Brown
Date: Wed Mar 23 2016 - 06:34:35 EST

On Wed, Mar 23, 2016 at 09:48:42AM +0100, Alexander Stein wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.

> I'm currently trying to get PCIe working on LS1021A (little-endian
> ARM). For link-detection I need access to a syscon perpheral (SCFG)
> which is attched to CPU as big-endian.

Are you *sure* that this is actually big endian? Are you basing this on
documentation or on what happened to work for you in the past.

> Based on current linus's master (a24e3d414e59ac765, "Merge branch
> 'akpm' (patches from Andrew)") I noticed the access is actually done
> as little-endian. I could track it down to commit 922a9f936e40001f
> ("regmap: mmio: Convert to regmap_bus and fix accessor usage").
> Reverting it, the access is fine now and I get my PCIe link.

Have you tried tracing through the code to see what ends up happening to
the I/O? It should come out using your architecture's big endian

Attachment: signature.asc
Description: PGP signature