Re: regmap: mmio: regression in pre-v4.6-rc1

From: Mark Brown
Date: Wed Mar 23 2016 - 08:05:56 EST

On Wed, Mar 23, 2016 at 12:50:53PM +0100, Alexander Stein wrote:

As I said previously please fix your mail client to word wrap within
paragraphs at something substantially less than 80 columns. Doing this
makes your messages much easier to read and reply to.

> > > In regmap_mmio_gen_context ctx->reg_read is set to regmap_mmio_read32le and
> > > ctx->reg_write to regmap_mmio_write32le respectively.

> > So how does that happen then? We set these values if the bus is
> > default, little or native endian but if it's big endian we go into a
> > completely different case...

> Well, in regmap_mmio_gen_context config->reg_format_endian is still
> set to REGMAP_ENDIAN_DEFAULT. of_syscon_register sets
> config.val_format_endian (notice val_ instead of reg_) depending on
> "big-endian" (or "little-endian") property. I'm kinda confused
> regarding reg_format_endian and val_format_endian. Dunno what should
> be set in which way.

Ah, I see. That's definitely broken - if we're changing the value
format we should be checking the value.

Attachment: signature.asc
Description: PGP signature