Re: [PATCH v2 05/11] dt-bindings: Add bindings for phy-da8xx-usb

From: David Lechner
Date: Wed Mar 23 2016 - 13:56:48 EST

On 03/23/2016 12:06 PM, Sekhar Nori wrote:
On Thursday 17 March 2016 07:56 AM, David Lechner wrote:
Device tree binding for new phy-da8xx-usb driver.

Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>

v2 changes: This is new patch in v2.

.../devicetree/bindings/phy/phy-da8xx-usb.txt | 34 ++++++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt

diff --git a/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
new file mode 100644
index 0000000..ed6b710
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/phy-da8xx-usb.txt
@@ -0,0 +1,34 @@
+Required properties:
+ - compatible: must be "ti,da830-usbphy".
+ - #phy-cells: must be 1.
+ - reg : Address and length of the CFGCHIP2 register.

I am not sure passing CFGCHIP2 register as reg property to the phy is
future proof. At some point, we do want to move to common clock
framework and at that point USB clocks controlled by CFGCHIP2 will be a
separate driver needing access to the same register.

So I think the CFGCHIP2 access in USB phy driver should happen through a
syscon phandle. This needs to happen now, not later since we cannot
break DT backward-compatibility.

I think using "syscon" for the CFGCHIP registers makes sense (based on my minimal experience). Would we want one "syscon" device node that includes all of the CFGCHIP registers or one each?

Something like this?

cfgchip@1417C {
compatible = "ti,da830-cfgchip", "syscon";
reg = <1417C 20>;

or this?

cfgchip0@1417C {
compatible = "ti,da830-cfgchip0", "syscon";
reg = <1417C 4>;

cfgchip1@14180 {
compatible = "ti,da830-cfgchip1", "syscon";
reg = <14180 4>;



Would it be OK if the PHY driver registered clocks? I'm guessing this falls into the category of "not such a good idea".