Re: [PATCH v6] acpi: Issue _OSC call for native thermal interrupt handling

From: Srinivas Pandruvada
Date: Wed Mar 23 2016 - 16:25:04 EST


On Wed, 2016-03-23 at 12:43 -0400, Linda Knippers wrote:
> I raised a general concern on a previous patch so I found a 1P server
> with Skylake and HWP to try.ÂÂThis doesn't qualify as a tested-by
> since all I did was apply the patch and boot the server but hey, it
> booted.
Thanks.

>
> I do have a question below...
>
[...]
> + if (ACPI_SUCCESS(acpi_run_osc(handle, &osc_context))) {
> > + acpi_hwp_native_thermal_lvt_set = true;
> > + kfree(osc_context.ret.pointer);
>
> There are other boot messages that indicate when something is
> happening
> with _OSC.ÂÂShould there be one for this?ÂÂOr is there some other
> obvious
> way one can know that this was set?
>
I am following model ofÂacpi_bus_osc_support, which issues _OSC for
global platform scope, where nothing is getting printed. If it is
useful, I don't mind adding a print.

Rafael,
What do you think?

Thanks,
Srinivas