Re: [PATCH resend] init/main.c: Simplify initcall_blacklisted()
From: Rasmus Villemoes
Date: Wed Mar 23 2016 - 19:54:42 EST
On Tue, Mar 22 2016, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes:
>> Using kasprintf to get the function name makes us look up the name
>> twice, along with all the vsnprintf overhead of parsing the format
>> string etc. It also means there is an allocation failure case to deal
>> with. Since symbol_string in vsprintf.c would anyway allocate an array
>> of size KSYM_SYMBOL_LEN on the stack, that might as well be done up
>> Moreover, since this is a debug feature and the blacklisted_initcalls
>> list is usually empty, we might as well test that and thus avoid
>> looking up the symbol name even once in the common case.
>> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Thanks. Andrew, can I get you to take it?