Re: [PATCH] mfd: syscon: include errno.h from header

From: Lee Jones
Date: Thu Mar 24 2016 - 07:05:33 EST


On Wed, 23 Mar 2016, Arnd Bergmann wrote:

> The syscon header uses the ENOTSUPP error constant, but doesn't
> include the header that defines it. This causes a build error
> after the imx pinctrl driver started using syscon:
>
> include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap':
> include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function)
> return ERR_PTR(-ENOTSUPP);
> ^~~~~~~~
>
> This adds the missing #include.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
> ---
> include/linux/mfd/syscon.h | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 1088149be0c9..40a76b97b7ab 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -16,6 +16,7 @@
> #define __LINUX_MFD_SYSCON_H__
>
> #include <linux/err.h>
> +#include <linux/errno.h>
>
> struct device_node;
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog