Re: [PATCH 04/11] mm/slab: factor out kmem_cache_node initialization code

From: Christoph Lameter
Date: Mon Mar 28 2016 - 20:56:26 EST


On Mon, 28 Mar 2016, js1304@xxxxxxxxx wrote:

> From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> - spin_lock_irq(&n->list_lock);
> - n->free_limit =
> - (1 + nr_cpus_node(node)) *
> - cachep->batchcount + cachep->num;
> - spin_unlock_irq(&n->list_lock);
> + ret = init_cache_node(cachep, node, GFP_KERNEL);
> + if (ret)
> + return ret;

Drop ret and do a

return init_cache_node(...);

instead?