Re: [PATCH] fs/vfs: improve __mnt_is_readonly

From: Yaowei Bai
Date: Tue Mar 29 2016 - 02:36:17 EST


On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
> > This patch refactors __mnt_is_readonly and makes it return bool to
> > improve readability due to this particular function only using either
> > one or zero as its return value.
>
> Improve in which way, if I may ask?

A boolean return value can be more matchable with function's name and
more suitable as this function only returns 0/1.