Re: [RESEND v2] phy: hi6220: Add missing MFD_SYSCON dependency on HAS_IOMEM

From: Krzysztof Kozlowski
Date: Wed Mar 30 2016 - 04:24:51 EST


On 30.03.2016 17:10, Lee Jones wrote:
> On Wed, 30 Mar 2016, Lee Jones wrote:
>
>> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>>
>>> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
>>> direct dependencies.
>>>
>>> This fixes warning on allyesconfig on ARCH=um:
>>>
>>> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X &&
>>> DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWMAC_SOCFPGA && DWMAC_STI && TI_CPSW
>>> && PINCTRL_ROCKCHIP && PINCTRL_DOVE && POWER_RESET_KEYSTONE &&
>>> S3C2410_WATCHDOG && VIDEO_OMAP3 && VIDEO_S5P_FIMC && USB_XHCI_MTK &&
>>> RTC_DRV_AT91SAM9 && LPC18XX_DMAMUX && VIDEO_OMAP4 && HWSPINLOCK_QCOM &&
>>> ATMEL_ST && QCOM_GSBI && PHY_HI6220_USB)
>>> selects MFD_SYSCON which has unmet direct dependencies (HAS_IOMEM)
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>>> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>>
>> Holding off on this until the discussion reaches some kind of
>> consensus.
>
> FYI: https://lkml.org/lkml/2016/3/29/716

Yes, Rob's solution looks better to me.

BR,
Krzysztof