Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

From: Dmitry Torokhov
Date: Thu Mar 31 2016 - 16:09:50 EST


On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote:
>
> > Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@xxxxxxxxxxxx> a écrit :
> >
> > Hello Andreas,
> >
> > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@xxxxxxx> wrote:
> >> Drop #address-cells and #size-cells, which are not required by the
> >> gpio-keys binding documentation, as button sub-nodes are not devices.
> >>
> >> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> >>
> >> While at it, adopt the dashes convention for the node name.
> >>
> >> Reported-by: Julien Chauveau <chauveau.julien@xxxxxxxxx>
> >> Cc: Julien Chauveau <chauveau.julien@xxxxxxxxx>
> >> Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxx>
> >> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >> Signed-off-by: Andreas Färber <afaerber@xxxxxxx>
> >> ---
> >
> > Patch looks good to me.
> >
> > Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>
> I agree.
>
> Reviewed-by: Julien Chauveau <chauveau.julien@xxxxxxxxx>

Applied, thank you.

--
Dmitry