Re: [PATCH v12 3/9] added UFS 2.0 capabilities

From: Joao Pinto
Date: Fri Apr 01 2016 - 05:21:14 EST


On 3/31/2016 9:27 PM, Winkler, Tomas wrote:
> On Thu, 2016-03-31 at 19:57 +0100, Joao Pinto wrote:
>> Adding UFS 2.0 support to the UFS core driver.
>>
>> Signed-off-by: Joao Pinto <jpinto@xxxxxxxxxxxx>
>
> Looks good to me, though not tested yet
> Tomas

I have tested the build in a x86 and ARC. Also tested the functionality by using
a HAPS-DX FPGA with the UFS 2.0 design + MPHY G210.

>
>> ---
>> Changes v11->v12 (Tomas Winkler):
>> - devicetree binding tweak was moved to a separated patch
>> - unipro tweaks were moved to a separated patch
>> - ufshcd_compose_upiu was decomposed in 2 functions

[snip]

>> +enum {
>> + UTP_CMD_TYPE_UFS_STORAGE = 0x1,
>> +};
>> +
>> enum {
>> UTP_SCSI_COMMAND = 0x00000000,
>> UTP_NATIVE_UFS_COMMAND = 0x10000000,

If you need anything else, please let me know.

Thanks.
Joao