Re: [PATCH v2 06/11] phy: da8xx-usb: new driver for DA8XX SoC USB PHY

[Sergei Shtylyov]

On 04/01/2016 07:02 PM, David Lechner wrote:

> > > > +EXPORT_SYMBOL_GPL(da8xx_usb20_phy_set_mode);
> > >
> > > Don't prefer export symbols from PHY driver. That'll create unnecessary
> > > dependencies between the controller and the PHY.
> >
> > Agreed.
> >
> > > I think it'll be better to create a new attribute and use it?
> >
> > Another simpler option is to not support _set_mode() for DA8xx, and the
> > phy driver set the otgmode bit in probe() based on dr_mode of the
> > controller.
> >
> > Regards,
> > -Bin.
>
> This certainly works for my particular use case, however, Sergei Shtylyov, who
> wrote the da8xx musb glue layer originally, seemed to recall in his review of
> the patch series that this really is necessary for OTG mode to work properly.

   No, it's still not necessary, however this method is now called from 
musb_init_controller() (it wasn't in my time). ISTR however that you needed to 
enforce the mode override in CFGCHIP2 for the host mode to function properly.

WBR, Sergei