Re: [PATCH 1/3] mm, oom: rework oom detection

From: Vladimir Davydov
Date: Mon Apr 04 2016 - 04:24:01 EST


On Tue, Dec 15, 2015 at 07:19:44PM +0100, Michal Hocko wrote:
...
> @@ -2592,17 +2589,10 @@ static bool shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> &nr_soft_scanned);
> sc->nr_reclaimed += nr_soft_reclaimed;
> sc->nr_scanned += nr_soft_scanned;
> - if (nr_soft_reclaimed)
> - reclaimable = true;
> /* need some check for avoid more shrink_zone() */
> }
>
> - if (shrink_zone(zone, sc, zone_idx(zone) == classzone_idx))
> - reclaimable = true;
> -
> - if (global_reclaim(sc) &&
> - !reclaimable && zone_reclaimable(zone))
> - reclaimable = true;
> + shrink_zone(zone, sc, zone_idx(zone));

Shouldn't it be

shrink_zone(zone, sc, zone_idx(zone) == classzone_idx);

?

> }
>
> /*