Re: [PATCH 1/3] intel_pstate: Use pr_fmt

From: Viresh Kumar
Date: Wed Apr 06 2016 - 11:01:26 EST


On 06-04-16, 07:51, Doug Smythies wrote:
> On 2016.04.05 02:44 Srinivas Pandruvada wrote:
> > On Tue, 2016-04-05 at 13:28 -0700, Joe Perches wrote:
> >> Prefix the output using the more common kernel style.
> >>
> >> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> >> ---
> >> drivers/cpufreq/intel_pstate.c | 18 ++++++++++--------
> >> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> ...[cut, example left]...
>
> > - pr_warn("intel_pstate: Turbo disabled by BIOS or
> > unavailable on processor\n");
> > + pr_warn("Turbo disabled by BIOS or unavailable on
> > processor\n");
>
> I do not understand.
> The common and unique string "intel_pstate" was added on purpose
> so as to provide a way to easily extract the related message from
> an otherwise huge log file.

The first line of the patch does this:

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

which will automagically add name of the current file (intel_pstate)
before every print message printed using pr_*() helpers.

--
viresh