Re: [PATCH] HID: simplify implement() a bit

From: Doug Anderson
Date: Wed Apr 06 2016 - 17:31:54 EST


Dmitry,

On Wed, Apr 6, 2016 at 10:19 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> The 'size' variable is not really needed, and we can also shift constant
> in the loop body when masking off existing bits.
>
> Also we do not have to us 64 bit calculations if we take an extra
> branch.
>
> Suggested-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/hid/hid-core.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>