RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

From: Rajesh Bhagat
Date: Sun Apr 10 2016 - 23:46:43 EST




> -----Original Message-----
> From: Mathias Nyman [mailto:mathias.nyman@xxxxxxxxxxxxxxx]
> Sent: Friday, April 01, 2016 4:20 PM
> To: Rajesh Bhagat <rajesh.bhagat@xxxxxxx>
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sriram Dash <sriram.dash@xxxxxxx>
> Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI
> commmand timeout
>
> On 01.04.2016 06:55, Rajesh Bhagat wrote:
>
> >>>
> >>> Please share your opinion on other changes for patch submission as
> >>> well as resume
> >> time.
> >>>
> >
> >>
> >> I think more effort should be put into investigating why this happens in the first
> place.
> >> What is the root cause? why doesn't xhci start properly after resume in this case.
> >>
> > Hello Mathias,
> >
> > I understand your point and would surely debug the root cause of the
> > issue. But implementing the fallback mechanism in SW, if HW does not respond well
> seems to a better solution to me.
> >
>
> Yes, I'll add something like this, at least the xhci parts to make sure the completions
> are called.
>

Should I send the patch?

> This is not really a fallback, it's just a better burial for xhci. It will be unusable after
> this.
>
> -Mathias