Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit()

From: Rusty Russell
Date: Tue Apr 12 2016 - 03:33:48 EST


Jiri Kosina <jikos@xxxxxxxxxx> writes:
> On Wed, 30 Mar 2016, Jiri Kosina wrote:
>
>> > __module_put_and_exit() is makred noreturn in module.h declaration, but is
>> > lacking the attribute in the definition, which makes some tools (such as
>> > sparse) unhappy. Amend the definition with the attribute as well (and
>> > reformat the declaration so that it uses more common format).
>> >
>> > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
>> > ---
>> >
>> > v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested
>> > by Rusty
>>
>> Rusty, friendly ping on this one.
>
> Not seeing this in your tree, let me send another friendly ping :)

Just pushed it into modules-next.

Cheers,
Rusty.